Fix/crosshairs annotations #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sedghi
commented
Nov 19, 2022
•
sedghi
commented
- Make Crosshairs to remove their annotations upon disabled
- Make annotation rendering engine to reset its rendering flags when a viewport is removed
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sedghi
force-pushed
the
fix/crosshairs-annotations
branch
from
84db1e1 to
26b125d
Compare
| @@ -210,6 +210,7 @@ class RenderingEngine implements IRenderingEngine { | |||
|
|
|||
| // 5. Remove the requested viewport from the rendering engine | |||
| this._removeViewport(viewportId); | |||
| viewport.hasBeenDisabled = true; | |||
There was a problem hiding this comment.
The naming here is very odd, and I think it ends up not being quite right. hasBeenDisabled doesn't mean it is currently disabled, but suggests that at some point in the past it got disabled. Is it safe to say:
viewport.isDisabled = true
or
viewport.disabled = true
Otherwise, what about making it more prescriptive, something like disableOverlayDrawing, so that it is specifying that no overlays are to be drawn this viewport, and that would include things like the crosshairs, but may also include things like segmentation overlays etc.
NeilMacPhee
pushed a commit
to NeilMacPhee/cornerstone3D-beta
that referenced
this pull request
Nov 22, 2022
* feat: add hasBeenDestroyed to viewport and fix bugs * fix: reset annotation render on remove element * new api * apply review comments
wayfarer3130
pushed a commit
that referenced
this pull request
Jan 20, 2023
…303) * feat(anonymizer) - export Array tagNamesToEmpty and add parameter in function cleanTags -> manage the tags to anonymize/modify in dicom * fix comma * return a copy of the list tagsNameToEmpty and then pass in the lists as optional arguments to cleanTags Co-authored-by: CASTELNEAU Julien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.