-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ROI threshold to consider two volumes for thresholding #325
Merged
sedghi
merged 21 commits into
cornerstonejs:main
from
RadicalImaging:feat/ROIThreshold_new
Jan 12, 2023
Merged
Changes from 9 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
eadae94
Adding ROI Threshold based on multiple volumes
rodrigobasilio2022 0b50ac9
Add sliders for petVolume
rodrigobasilio2022 b84d084
Refactoring threshold function parameters
rodrigobasilio2022 cb369d8
Working with LPS coords
rodrigobasilio2022 79bd35c
Running required checks
rodrigobasilio2022 c91ba23
Adding perfusion colormap
rodrigobasilio2022 b907ec9
Fix CI error in PR
rodrigobasilio2022 488485b
Fixing CI function parameter checking error
rodrigobasilio2022 2aec974
Fixing CI error related to api change
rodrigobasilio2022 48eb735
Removing unnecessary extra parameter
rodrigobasilio2022 17aed50
Minor parameter adjustment
rodrigobasilio2022 9524fd9
Add test coverType option
rodrigobasilio2022 84f35f6
Add some comments
rodrigobasilio2022 5e47114
Convert parameter in optional and set defaul value
rodrigobasilio2022 5e46d31
Convert parameter in optional and set defaul value
rodrigobasilio2022 f0585a6
Fixing CI errors
rodrigobasilio2022 e8c2a88
Refactoring and comment threshold functions
rodrigobasilio2022 168ed3f
Refactoring code based on PR reviews
rodrigobasilio2022 35753f7
Add spacing check between volumes in roi threshold
rodrigobasilio2022 8fee29c
Merge branch 'main' into feat/ROIThreshold_new
sedghi 47d4b22
fix build
sedghi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to put this here, the callback isn't getting a preset, it is using the
preset
from the surrounding