Dicom Loader Typescript Conversion #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: annotation highlighted and tooling for ellipticalROI * update build * fix tests
- [email protected] - @cornerstonejs/[email protected]
* fix: use focal point for pan cache for stack viewport * fix: pan dir with flip * fix pan values while flipped * update build * apply review comments * fix build
- @cornerstonejs/[email protected] - [email protected] - @cornerstonejs/[email protected] - @cornerstonejs/[email protected]
* added basic cursorCrosshairSync tool with example, TODO: for now cursorSync is displayed regardless of distance, create configurable distance and also sync the position of all viewports over which the mouse is not to scroll to a slice that is close to the currentMousePosition in 3d space * addde stack syncing for StackViewport and syncing for volumeViewport on imageChange events, added configuration for max display distance * refactored tool functions * added comment to possible bug * added configuration options to example * changed look of crosshair to 4 lines with central space * undid local tsconfig change * undid yarn.lock changes * added tool to example-info.json * removed from example-runner because it broke build * readded example and fixed typo * readded example-info and changed example to trigger rebuild * added cleanup for mouseoverElement when tool is disabled * added cleanup when tool gets disabled, this does not get called when toolGroup gets destroyed, might cause remaining listeners * applied naming changes, reworked adding annotation logic * removed event listeners and moved logic to check for stack scrolling into rendering logic * added planeDistanceToPoint to planar utilities * added getClosestStackImageIndexForPoint * rewrote logic to use onCameraModified * updated example-info * fixed bug with 0 being falsey * added logic to remove cursor if wanted * modified toolGroup so that setting a tool active only changes the cursor to default if there is no primary mouse cursor * fixed bug not updating disable cursor * fixed missing parentheses from merge * readded scrollWheel scrolling and api changes * fixed typos
- @cornerstonejs/[email protected] - [email protected] - @cornerstonejs/[email protected] - @cornerstonejs/[email protected]
- [email protected] - @cornerstonejs/[email protected]
Co-authored-by: edward65 <[email protected]>
…qual normals. (cornerstonejs#315) Co-authored-by: Ramon Emiliani <[email protected]>
* limit disabled element not need to render * Update BaseTool.ts fix: get correct viewport when there are multiple viewport with same stack data Co-authored-by: chendingmiao <[email protected]>
- [email protected] - @cornerstonejs/[email protected]
* fix(htj2k):Support htj2k in the streaming volume loader * fix(decodeImage):Fix htj2k image decode and mouse key modifiers * Update for PR * update ci build
- [email protected] - @cornerstonejs/[email protected] - @cornerstonejs/[email protected]
- @cornerstonejs/[email protected] - [email protected] - @cornerstonejs/[email protected] - @cornerstonejs/[email protected]
…js#309) * fix rotation for handles * fix: short axis movement * fix: bidirectional tool incorrect interaction
- @cornerstonejs/[email protected] - [email protected] - @cornerstonejs/[email protected] - @cornerstonejs/[email protected]
…ned (cornerstonejs#323) While trying to get the volume from the cache, it can be undefined so getting the scaling attribute would throw an error in that case. This is a quick fix
- @cornerstonejs/[email protected] - [email protected] - @cornerstonejs/[email protected] - @cornerstonejs/[email protected]
- [email protected] - @cornerstonejs/[email protected]
❌ Deploy Preview for cornerstone-3d-docs failed.
|
|
This is a great start! Thanks
|
|
Thanks @sedghi |
sedghi
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #310 I have updated the bulk of the CornerstoneWadoLoad/DicomLoader package to typescript.
I have added
@todocomments throughout where there appear to be issues. I have also had to use manyas anyescape hatches to work around the legacy code.