-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CobbAngle): Add CobbAngle tool #353
Conversation
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff
Two things
-
Trying the example here, user should be able to drag and draw both lines. I can drag and draw the first one, but for some reason I can't drag and draw the second line. I only can click and draw second one. Maybe there is some limitation in our toolings and it is not this PR
-
For ui/ux I would like to see some linking between the pairs, as it gets out of hand which one is paired with which one. This tool is often used in spine and you can guess what happens.
I looked into other viewers, and there are some sort of linkings between them.
Another one here
https://youtu.be/7XpYu-AjW0c?t=99
I honestly think doing something similar to meddream is like 10 mins of work (finding the middle of both lines and draw a dashed line). Can we have that please?
a5d4c79
to
e56c65e
Compare
f7cc55f
to
dc38a45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a9e0f78
to
f44e681
Compare
f44e681
to
580b03a
Compare
Add a Cobb Angle implementation for CS3D.
Added to the examples that have AngleTool so that it can be compared.