Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tools): Some older annotations were missing normal #528

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix(tools): Some older annotations were missing normal #528

merged 1 commit into from
Mar 28, 2023

Conversation

wayfarer3130
Copy link
Collaborator

Added a computation for the image normal when an annotation is missing the normal vector.

@wayfarer3130 wayfarer3130 requested a review from sedghi March 28, 2023 19:05
@netlify
Copy link

netlify bot commented Mar 28, 2023 •
edited
Loading

✅ Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit ac769c7
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/64233a6d13d34500088f9e07
😎 Deploy Preview https://deploy-preview-528--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@wayfarer3130 wayfarer3130 merged commit 319822a into main Mar 28, 2023
@wayfarer3130 wayfarer3130 deleted the fix/load-sr-without-normal branch March 28, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedghi sedghi sedghi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wayfarer3130 @sedghi