Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix triggering of 'ANNOTATION_ADDED' event multiple times (#570) #584

Merged
merged 1 commit into from
Apr 28, 2023
Merged

fix triggering of 'ANNOTATION_ADDED' event multiple times (#570) #584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/tools/src/stateManagement/annotation/annotationState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,13 @@ function addAnnotation(
// annotation added event for that element.
if (annotationGroupSelector instanceof HTMLDivElement) {
triggerAnnotationAddedForElement(annotation, annotationGroupSelector);
} else {
// if no element is provided, render all viewports that have the
// same frame of reference.
// Todo: we should do something else here for other types of annotation managers.
triggerAnnotationAddedForFOR(annotation);
}

// if no element is provided, render all viewports that have the
// same frame of reference.
// Todo: we should do something else here for other types of annotation managers.
triggerAnnotationAddedForFOR(annotation);

return annotation.annotationUID;
}

Expand Down