fix: change package.json 'module' field to use '.js' extension from '.ts' #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow I'm a moron yeah that should definitely be pointing to the .js index. Probably a typo from when I was experimenting with it. In our tests and examples we consume the src via aliases, not the actual built version so that's probably why we hadn't noticed yet. This also needs to be changed for the other two packages in the tools and streaming-image-volume-loader folders. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'module' field in package.json should probably use a '.js' extension instead of '.ts'. The generated output files located in
packages/core/dist/esmdon't actually include any .ts files. Changing the extension resolves build issues experienced in Vite when importing the ESM build of @cornerstonejs/core.Discussion here: #64