Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monochrome1): fix bug for monochrom1 inverted color #668

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Jun 23, 2023

Context

If the stack has multiple monochrome1 images, it cannot invert the images, and only the first image looks correct. Fixes #628

Also fixes #656 since web image loader does not have imageFrame

Changes & Results

force recreate the transfer function if monochrome1

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

@netlify
Copy link

netlify bot commented Jun 23, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 43ea527
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6494fec9f3a32400087a969f
😎 Deploy Preview https://deploy-preview-668--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sedghi sedghi changed the title fix/grey scale volume slice fix(monochrome1): fix bug for monochrom1 inverted color Jun 23, 2023
@wayfarer3130 wayfarer3130 merged commit 0864049 into main Jun 27, 2023
@wayfarer3130 wayfarer3130 deleted the fix/grey-scale-volume-slice branch June 27, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants