Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(colorbar): add viewport colorbar #825

Merged
merged 14 commits into from
Oct 25, 2023
Merged

feat(colorbar): add viewport colorbar #825

merged 14 commits into from
Oct 25, 2023

Conversation

lscoder
Copy link
Collaborator

@lscoder lscoder commented Oct 12, 2023 •
edited
Loading

colorbar.mp4

@netlify
Copy link

netlify bot commented Oct 12, 2023 •
edited
Loading

✅ Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 7760fec
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/65396227d7e17c0008501e64
😎 Deploy Preview https://deploy-preview-825--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lscoder lscoder marked this pull request as draft October 12, 2023 14:57
@lscoder lscoder marked this pull request as ready for review October 20, 2023 11:29
sedghi
sedghi reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my remaining comments, also the ones that still remains unresolved

@lscoder lscoder requested a review from sedghi October 25, 2023 15:12
sedghi
sedghi approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work as always

@sedghi sedghi changed the title feat(colorbar): PET colorbar feat(colorbar): add viewport colorbar Oct 25, 2023
@sedghi sedghi merged commit 9f17218 into cornerstonejs:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedghi sedghi sedghi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lscoder @sedghi