Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(segmentation): Add polymorph segmentation and representation conversion capabilities #844

Merged
merged 126 commits into from
Feb 7, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Oct 20, 2023

  • 👏 Kudos to Mo Alsad (@moalasad) from XNAT team and ICR for their amazing new repository polySEG-wasm to put the ground work for the WASM converters, and also kudos to @rodrigobasilio2022 who did an excellent job by adding the remaining converters. 🎉

Changes & Results

polymorph segmentation is the idea of "Segmentation object storing each structure of an entity with each representation in one data object" formulated and developed initially by @cpinter and 3D Slicer.

image

image

Through the development of Cornerstone3D, we aimed to address the separation between representation and segmentation. We built the segmentation framework around it, initially providing the Labelmap representation.

This PR will add the capability to create/compute different representations from each other without a breaking change.

This PR incorporates the necessary logic and connectors into the internals of cornerstone3D. It also enables the execution of each conversion within a web worker to prevent the main thread from being blocked. Enjoy!

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 4a4b044
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/65c2b0b87612260008cd13c5
😎 Deploy Preview https://deploy-preview-844--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi changed the title Add wasm conversion contour 2 surface Add polyseg converters Oct 20, 2023
@sedghi sedghi requested a review from wayfarer3130 February 5, 2024 21:59
Copy link
Collaborator

@wayfarer3130 wayfarer3130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@sedghi sedghi merged commit ac21d9f into main Feb 7, 2024
9 checks passed
@sedghi sedghi deleted the new-polyseg-wasm branch January 22, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants