-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(segmentation): Add polymorph segmentation and representation conversion capabilities #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/rodrigobasilio2022/feat(wasm)--AddPollySegWasm
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ne3D into new-polyseg-wasm
… and update hoverTimeout in SegmentSelectTool.ts
wayfarer3130
reviewed
Feb 6, 2024
wayfarer3130
reviewed
Feb 6, 2024
packages/tools/src/tools/displayTools/Contour/contourDisplay.ts
Outdated
Show resolved
Hide resolved
wayfarer3130
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polySEG-wasm
to put the ground work for the WASM converters, and also kudos to @rodrigobasilio2022 who did an excellent job by adding the remaining converters. 🎉Changes & Results
polymorph segmentation is the idea of "Segmentation object storing each structure of an entity with each representation in one data object" formulated and developed initially by @cpinter and 3D Slicer.
Through the development of Cornerstone3D, we aimed to address the separation between representation and segmentation. We built the segmentation framework around it, initially providing the Labelmap representation.
This PR will add the capability to create/compute different representations from each other without a breaking change.
This PR incorporates the necessary logic and connectors into the internals of cornerstone3D. It also enables the execution of each conversion within a web worker to prevent the main thread from being blocked. Enjoy!
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-api
to update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment