fix(metadata): exceptions trying to use the metadata providers #902
+17
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
approved these changes
Nov 21, 2023
sedghi
requested changes
Nov 21, 2023
There was a problem hiding this comment.
I think this is once again a side effect of the HTJ2K metadata provider changes. We should modify it to match the signature of others. You can extract the third argument 'stack' from the provider in a different way. I believe we have inadvertently affected several other custom providers in people's apps with this change.
sedghi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A recent change started making use of non-string parameters for metadata query, causing some providers to fail. Instead, use varargs for the providers needing more than one query argument.
Changes & Results
Use varargs.
Testing
Run OHIF linked to CS3d, plus the examples htj2kStackBasic and htj2kVolumeBasic. They should still run progressively.
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment