fix: Inclusion of this build in OHIF was causing an import loop #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wayfarer3130
commented
Nov 24, 2023
| import { Annotations } from '../../types'; | ||
| import { annotationFrameRange } from '..'; | ||
| import type { Annotations } from '../../types'; | ||
| import annotationFrameRange from '../annotationFrameRange'; |
There was a problem hiding this comment.
This line caused the bug - we depended on that class, which depended on the import, which depended on this class - throwing an exception. Why they couldn't detect that I don't know.
sedghi
approved these changes
Nov 24, 2023
|
Glad it's fixed, it took me hours trying to find the problem, but failed. Did you use any tools to find the import loop? |
|
@luxl Not really |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There was an import that ended up importing itself and trying to resolve all the imports along the way, introduced in the video code.
Changes & Results
Use direct import instead of import via the group/namespace files.
Testing
Link core/tools into OHIF. Start OHIF - if it starts, the fix worked.
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment