Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add CINE tool via playClip #99

Merged
merged 5 commits into from
May 12, 2022
Merged

feat: Add CINE tool via playClip #99

merged 5 commits into from
May 12, 2022

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented May 12, 2022

No description provided.

@sedghi sedghi requested a review from JamesAPetts May 12, 2022 03:16
JamesAPetts
JamesAPetts requested changes May 12, 2022
View reviewed changes
Copy link
Member

@JamesAPetts JamesAPetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but one major one:

At the minimum: we need an example page with a single stack viewport that demonstrates playClip and stopClip, and has a slider for the framerate from like 1-90 fps.

packages/tools/src/utilities/cine/playClip.ts Outdated Show resolved Hide resolved
packages/tools/src/utilities/cine/playClip.ts Outdated Show resolved Hide resolved
packages/tools/src/utilities/cine/playClip.ts Outdated Show resolved Hide resolved
packages/tools/src/utilities/cine/state.ts Outdated Show resolved Hide resolved
packages/tools/src/utilities/cine/playClip.ts Outdated Show resolved Hide resolved
packages/tools/src/utilities/cine/playClip.ts Outdated Show resolved Hide resolved
packages/tools/src/utilities/cine/playClip.ts Outdated Show resolved Hide resolved
packages/tools/src/utilities/cine/events.ts Show resolved Hide resolved
@sedghi sedghi requested a review from JamesAPetts May 12, 2022 13:33
JamesAPetts
JamesAPetts approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@JamesAPetts JamesAPetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny task then feel free to merge.

packages/tools/src/utilities/cine/playClip.ts Outdated Show resolved Hide resolved
@sedghi sedghi merged commit 916d783 into main May 12, 2022
@swederik swederik deleted the feat/cine-tool branch July 8, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesAPetts JamesAPetts JamesAPetts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sedghi @JamesAPetts