Change Custom tooltips key to External #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it works with latest version of Chart.js
coroo
requested changes
Feb 16, 2023
| @@ -161,7 +161,7 @@ | |||
|
|
|||
| if(this.chartTooltips !== undefined){ | |||
| this.options.plugins.tooltip = this.chartTooltips; | |||
| const tooltiplist = ["custom", "itemSort", "filter"]; | |||
| const tooltiplist = ["external", "itemSort", "filter"]; | |||
There was a problem hiding this comment.
is it only applicable for stackedChart? I think it is also applicable to another chart? cmiiw.
If yes, can you help to update another from custom to another?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it works with the latest version of Chart.js https://www.chartjs.org/docs/latest/getting-started/v3-migration.html#tooltip
tooltips.custom was renamed to plugins.tooltip.externalI was thinking about leaving both keys working for compatibility but everyone will still need to change external tooltip functions because it now has different content of the property