add GetHeaders to the Response interface (#3338)

Signed-off-by: Ben Ye <[email protected]>
cortexproject · Oct 13, 2020 · 21bad57 · 21bad57
1 parent d3ab152
commit 21bad57
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/pkg/querier/queryrange/query_range.go b/pkg/querier/queryrange/query_range.go
@@ -87,6 +87,8 @@ type Request interface {
 // Response represents a query range response.
 type Response interface {
 	proto.Message
+	// GetHeaders returns the HTTP headers in the response.
+	GetHeaders() []*PrometheusResponseHeader
 }
 
 type prometheusCodec struct{}

diff --git a/pkg/querier/queryrange/results_cache.go b/pkg/querier/queryrange/results_cache.go
@@ -255,14 +255,12 @@ func (s resultsCache) shouldCacheResponse(ctx context.Context, r Response) bool
 }
 
 func getHeaderValuesWithName(r Response, headerName string) (headerValues []string) {
-	if promResp, ok := r.(*PrometheusResponse); ok {
-		for _, hv := range promResp.Headers {
-			if hv.GetName() != headerName {
-				continue
-			}
-
-			headerValues = append(headerValues, hv.GetValues()...)
+	for _, hv := range r.GetHeaders() {
+		if hv.GetName() != headerName {
+			continue
 		}
+
+		headerValues = append(headerValues, hv.GetValues()...)
 	}
 
 	return