Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated chunk storage flag #5940

Merged
merged 3 commits into from
May 10, 2024

Conversation

alanprot
Copy link
Member

@alanprot alanprot commented May 9, 2024

What this PR does:
Removing deprecated chunk storage flag.

This flag was used on chunk storage but we removed chunk storage 2 releases ago.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • [NA] Tests updated
  • Documentation added
  • [NA] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks, just need to fix lint

Signed-off-by: alanprot <[email protected]>
@alanprot alanprot enabled auto-merge (squash) May 9, 2024 20:45
@friedrichg
Copy link
Member

ok  	github.com/cortexproject/cortex/pkg/configs/userconfig	1.037s
--- FAIL: TestLoadRuntimeConfig_ShouldLoadAnchoredYAML (0.00s)
    runtime_config_test.go:33: 
        	Error Trace:	/__w/cortex/cortex/pkg/cortex/runtime_config_test.go:33
        	Error:      	Received unexpected error:
        	            	yaml: unmarshal errors:
        	            	  line 9: field max_series_per_query not found in type validation.plain
        	            	  line 9: field max_series_per_query not found in type validation.plain
        	            	  line 9: field max_series_per_query not found in type validation.plain
        	Test:       	TestLoadRuntimeConfig_ShouldLoadAnchoredYAML

this error looks related

Signed-off-by: alanprot <[email protected]>
@alanprot alanprot merged commit 02254ea into cortexproject:master May 10, 2024
16 checks passed
@alanprot alanprot deleted the deprecating-not-used-flags branch May 10, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants