Fix: expanded postings can cache wrong data when queries are issued "in the future" #6562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
fix/6556
branch
2 times, most recently
from
5bc90ec to
dba615b
Compare
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
…ter the last sample added in the head Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
yeya24
reviewed
Jan 29, 2025
yeya24
approved these changes
Jan 29, 2025
My bad.. i added to the unit test.. lemme add some on the fuzz test as well. We do not have expanded postings for get series for now but is good to add in case we add cache there in the future. |
Signed-off-by: alanprot <[email protected]>
|
@yeya24 Added the get series fuzzy testing. |
alanprot
changed the title
CharlieTLe
pushed a commit
to CharlieTLe/cortex
that referenced
this pull request
Jan 30, 2025
…in the future" (cortexproject#6562) * improve fuzz test for expanded postings cache Signed-off-by: alanprot <[email protected]> * create more tests on the expanded postings cache Signed-off-by: alanprot <[email protected]> * adding get series call on the test Signed-off-by: alanprot <[email protected]> * no use CachedBlockChunkQuerier when query time range is completely after the last sample added in the head Signed-off-by: alanprot <[email protected]> * adding comments Signed-off-by: alanprot <[email protected]> * increase the number of fuzz test from 100 to 300 Signed-off-by: alanprot <[email protected]> * add get series fuzzy testing Signed-off-by: alanprot <[email protected]> --------- Signed-off-by: alanprot <[email protected]>
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
Jan 31, 2025
…in the future" (cortexproject#6562) * improve fuzz test for expanded postings cache Signed-off-by: alanprot <[email protected]> * create more tests on the expanded postings cache Signed-off-by: alanprot <[email protected]> * adding get series call on the test Signed-off-by: alanprot <[email protected]> * no use CachedBlockChunkQuerier when query time range is completely after the last sample added in the head Signed-off-by: alanprot <[email protected]> * adding comments Signed-off-by: alanprot <[email protected]> * increase the number of fuzz test from 100 to 300 Signed-off-by: alanprot <[email protected]> * add get series fuzzy testing Signed-off-by: alanprot <[email protected]> --------- Signed-off-by: alanprot <[email protected]> Signed-off-by: Alex Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
See: #6556
This PR includes:
Additionally, we improved the prom to include all the matchers types: cortexproject/promqlsmith#142
Which issue(s) this PR fixes:
Fixes #6556
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]