Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable at modifier to walkinfo #137

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Disable at modifier to walkinfo #137

merged 1 commit into from
Nov 21, 2024

Conversation

SungJin1212
Copy link
Contributor

@SungJin1212 SungJin1212 commented Nov 21, 2024 •
edited
Loading

Disable at modifier to walkinfo function to prevent panic.

FYI. panic log in Prometheus

prometheus: ts=2024-11-21T01:31:32.562Z caller=engine.go:1089 level=error component="query engine" msg="runtime panic during query evaluation" expr="-ceil(info({__name__=\"test_series_a\",status_code=\"404\"}, {__name__=\"test_series_a\",job=\"test\"} @ 1732149073.310))" err="interface conversion: parser.Expr is *parser.StepInvariantExpr, not *parser.VectorSelector" stacktrace="goroutine 483 [running]:

yeya24
yeya24 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@yeya24 yeya24 merged commit 8b48fe2 into cortexproject:main Nov 21, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SungJin1212 @yeya24