Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Departmental Telephones #458

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

KittenColony
Copy link
Contributor

@KittenColony KittenColony commented Nov 3, 2024

About the PR

Ports RMC's rotary phone system to allow for inter-departmental communication outside of common and in-person conversation.

Why / Balance

It's a cool idea, it would also allow people to make requests more directly with other departments without needing to walk across the station to ask them, which work as a 1-1 communication line adjacent to Holopads

Technical details

I wish I knew.

Media

:todo:

SPRITES WILL BE CHANGED ONCE CODE WORKS.

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑
add: Added new departmental telephones

does not change actual contents, everything still says RMC
PLEASE GOD DONT FUCKING BREAK D:

Changes all namespaces into CD,

Content.Server/_CD/Telephone/TelephoneSystem.cs MIGHT explode badly so if it doesn't work check that first
Copy link
Contributor

github-actions bot commented Nov 3, 2024

RSI Diff Bot; head commit c2d6cd9 merging into 19d7453
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_CD/Objects/phone.rsi

State Old New Status
rpb_phone Added

Resources/Textures/_CD/Structures/rotary_phone.rsi

State Old New Status
rotary_phone Added
rotary_phone_ear Added
rotary_phone_ring Added

Edit: diff updated after c2d6cd9

@KittenColony
Copy link
Contributor Author

headache.

@dffdff2423
Copy link
Collaborator

Do you still intend to work on this in-light of Holopads and PDA messaging being added?

@KittenColony
Copy link
Contributor Author

Do you still intend to work on this in-light of Holopads and PDA messaging being added?

I don't see a reason not to even with those being added, though the PR is a draft due to me not knowing C#

@dffdff2423
Copy link
Collaborator

If you are not working on this is it alright if you close it? You should be able to re-open PRs that you close yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants