Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PATCH to http methods #34

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Add PATCH to http methods #34

merged 1 commit into from
Jul 23, 2020

Conversation

kgdiem
Copy link
Contributor

@kgdiem kgdiem commented Jul 23, 2020

PATCH is referenced but missing in the HTTP Methods object.

https://github.com/cosmicjs/cosmicjs-node/blob/master/src/bucket/object.js#L162

@kgdiem
Copy link
Contributor Author

kgdiem commented Jul 23, 2020

This is causing calls to, eg editObjectMetafields, to be called as a GET, will complete without throwing an exception at least in this case, but will not actually make the PATCH request to update the data as intended

@jazibsawar jazibsawar merged commit 783160f into cosmicjs:master Jul 23, 2020
@jazibsawar
Copy link
Contributor

@kgdiem Thanks for helping to find this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgdiem @jazibsawar