-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update asset lists for mantra mainnet and dukong testnet #5773
base: master
Are you sure you want to change the base?
update asset lists for mantra mainnet and dukong testnet #5773
Conversation
mantrachain/assetlist.json
Outdated
"name": "USDC", | ||
"display": "usdc", | ||
"symbol": "USDC", | ||
"coingecko_id": "usd-coin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, we only register coingecko_id on the original asset (and not ibc-transferred tokens)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeremyParish69 Noted, it got removed so it can be merged 👍
Ultimately we would like to leverage the coingecko_id
for each asset so we could rely on it in some frontend Dapps
Do you know when and which id we could use for the USDC here in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, there isn't any approriate cgid to have here.
The coingecko ID can be derived via the data in the traces
property, but I understand that many apps don't implement the logic to derive it.
In the future this may be expanded to allow IBC-transferred tokens to share the original coingecko ID, but at the moment we don't do this.
{ | ||
"type": "ibc", | ||
"counterparty": { | ||
"chain_name": "cosmoshub", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likewise, this would be "cosmoshubtestnet"
"counterparty": { | ||
"chain_name": "osmosistestnet", | ||
"base_denom": "uosmo", | ||
"channel_id": "channel-9126" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the correct channel ID
https://github.com/cosmos/chain-registry/blob/master/testnets/_IBC/mantrachaintestnet-osmosistestnet.json#L20
"counterparty": { | ||
"chain_name": "nobletestnet", | ||
"base_denom": "ausdy", | ||
"channel_id": "channel-237" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the correct channel id
https://github.com/cosmos/chain-registry/blob/master/testnets/_IBC/mantrachaintestnet-nobletestnet.json
No description provided.