build: push automatically to buf #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
suggested changes
Nov 9, 2022
There was a problem hiding this comment.
Wait, just thinking, do we want to push to buf on each change? This would make PRs like #93 proto-breaking.
How about pushing to buf on tag?
Currently, this is what we do for the SDK (push on every proto changes). Then we have a commit that is linked to a version until buf improve their tagging mechanism. |
julienrbrt
force-pushed
the
julien/push-buf
branch
from
aee2d00 to
5c6bee3
Compare
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in
cosmos.protoaren't automatically pushed to buf: https://buf.build/cosmos/cosmos-proto/commits/mainI have already added the buf token.
To be merged AFTER #93