Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode/Decode Transaction Documentation #10102

Closed
3 of 4 tasks
ryanchristo opened this issue Sep 8, 2021 · 0 comments · Fixed by #10133
Closed
3 of 4 tasks

Encode/Decode Transaction Documentation #10102

ryanchristo opened this issue Sep 8, 2021 · 0 comments · Fixed by #10133
Assignees
@ryanchristo
Labels
good first issue T:Docs Changes and features related to documentation.

Comments

@ryanchristo
Copy link
Contributor

ryanchristo commented Sep 8, 2021 •
edited
Loading

Summary

Documentation for encoding/decoding a transaction is limited. An example for encoding a transaction programmatically with go exists in generating, signing and broadcasting a transaction. We should include an example of encoding a transaction using the CLI before broadcasting a transaction with gRPC and REST. We should also include examples for decoding a transaction.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ryanchristo ryanchristo added good first issue T:Docs Changes and features related to documentation. labels Sep 8, 2021
@ryanchristo ryanchristo mentioned this issue Sep 13, 2021
Merged
13 tasks
@ryanchristo ryanchristo self-assigned this Sep 13, 2021
@mergify mergify bot closed this as completed in #10133 Sep 14, 2021
mergify bot pushed a commit that referenced this issue Sep 14, 2021
@ryanchristo
docs: encode/decode transaction (#10133)
a70f39e 
## Description

Closes: #10102

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

Adds examples for encoding/decoding a transaction using the CLI. Also fixes CLI use and description.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct `docs:` prefix in the PR title
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the [documentation writing guidelines](https://github.com/cosmos/cosmos-sdk/blob/master/docs/DOC_WRITING_GUIDELINES.md)
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct `docs:` prefix in the PR title
- [ ] confirmed all author checklist items have been addressed 
- [ ] confirmed that this PR only changes documentation
- [ ] reviewed content for consistency
- [ ] reviewed content for thoroughness
- [ ] reviewed content for spelling and grammar
- [ ] tested instructions (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanchristo ryanchristo

Labels
good first issue T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: encode/decode transaction cosmos/cosmos-sdk
1 participant
@ryanchristo