Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flesh out ICS0 and specify the API and whether it should be an import or it's own module #1943

Closed
adrianbrink opened this issue Aug 8, 2018 · 1 comment · Fixed by #12786
Closed

Flesh out ICS0 and specify the API and whether it should be an import or it's own module #1943

adrianbrink opened this issue Aug 8, 2018 · 1 comment · Fixed by #12786

Comments

@adrianbrink
Copy link
Contributor

No description provided.

@cwgoes
Copy link
Contributor

cwgoes commented Sep 26, 2018

Closing in favor of #1904.

@cwgoes cwgoes closed this as completed Sep 26, 2018
@JeancarloBarrios JeancarloBarrios mentioned this issue Aug 1, 2022
Merged
19 tasks
mergify bot pushed a commit that referenced this issue Aug 3, 2022
@JeancarloBarrios
fix: prevent panic on depinject when input or output struct has an un… (
7103587 
#12786)

…exported fild



## Description

Closes: #1943



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent panic on depinject when input or output struct has an un… cosmos/cosmos-sdk
2 participants
@adrianbrink @cwgoes