Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test_sim_gaia_import_export #2873

Closed
rigelrozanski opened this issue Nov 20, 2018 · 2 comments
Closed

improve test_sim_gaia_import_export #2873

rigelrozanski opened this issue Nov 20, 2018 · 2 comments
Labels
T: Tests Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@rigelrozanski
Copy link
Contributor

Couple things we ought to improve upon:

  • Based on our historical experiences, we should always avoid using scripts whenever possible for maintainability, In this situation, I think we could easily replicate the functionality of scripts/import-export-sim.sh in golang and therefor should
  • Also we should provide better output when a test fails here as to the exact command to run in order to replicate the error... right now we just say seed XX failed! when it would be good to say " run the following command: _____________________

CC @cwgoes

@rigelrozanski rigelrozanski added post-launch T: Tests Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Nov 20, 2018
@cwgoes
Copy link
Contributor

cwgoes commented Nov 20, 2018

At the moment I think we can't do it in Golang, too many of our libraries are not Goroutine-safe. I have tried this in the past with parallel simulations and needed to switch to bash scripts for that reason.

Agreed on better output.

@rigelrozanski
Copy link
Contributor Author

hmmm - we should document that information maybe in a readme.md in scripts/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Tests Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

No branches or pull requests

2 participants