Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Simulation spring cleaning #2930

Merged
merged 14 commits into from
Nov 29, 2018
Merged

R4R: Simulation spring cleaning #2930

merged 14 commits into from
Nov 29, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Nov 28, 2018 •
edited
Loading

Closes #2832
Closes #2902
Closes #2873
Closes #2885

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes mentioned this pull request Nov 28, 2018
Closed
@cwgoes cwgoes changed the title WIP: Simulation spring cleaning R4R: Simulation spring cleaning Nov 28, 2018
rigelrozanski
rigelrozanski approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

scripts/README.md Outdated Show resolved Hide resolved
cmd/gaia/app/sim_test.go Show resolved Hide resolved
x/slashing/simulation/invariants.go Show resolved Hide resolved
@alexanderbez
Copy link
Contributor

Merged in the latest develop and simulation seems to fail?

@cwgoes
Copy link
Contributor Author

cwgoes commented Nov 29, 2018

@alexanderbez Fixed.

alexanderbez
alexanderbez approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and concise changes -- thanks @cwgoes

@cwgoes cwgoes merged commit b2b026b into develop Nov 29, 2018
@cwgoes cwgoes deleted the cwgoes/simulation-spring-cleaning branch November 29, 2018 15:17
@HaoyangLiu HaoyangLiu mentioned this pull request Dec 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
C:Simulations T: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwgoes @alexanderbez @rigelrozanski