Move --pruning flag from gaiad start into gaiad.toml

[ValarDragon]

Many full nodes are likely to not notice the --pruning flag on gaiad start, I think this should near-term be placed within gaiad.toml. (In the longer term, perhaps it may need to shuffle for state syncing, though I don't expect that to be the case)

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

What do we gain here @ValarDragon? If most validator's don't notice it or know about it, will adding it to the node/server config help? IMHO, it should not be removed from the CLI but also added to the config file (similar to --minimum-gas-prices) as you've suggested.

[ValarDragon]

Given that all nodes have to configure the toml for min fees, I think they'd notice

[alexanderbez]

@ValarDragon they don't have to configure the toml. They can simply run gaiad start --minimum-gas-prices=... --pruning=....

[ValarDragon]

Makes sense, then I think it should be included in the toml as well then :)

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $86,359.87 more funded OSS Work available on the Gitcoin Issue Explorer

[davidkaufman]

Happy to add this new configuration setting to the configuration file. I’ll move the option processing code, if necessary, so that it’s shared by both the CLI option and config file directive, of course. I am new to go but eager to learn, and sure to get this done in a quickly!

Thanks!

-dave

[spm32]

You're good to go @davidkaufman!

[gitcoinbot]

@davidkaufman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@davidkaufman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@davidkaufman due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@davidkaufman due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[davidkaufman]

/me studies go... :-)

[gitcoinbot]

@davidkaufman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@davidkaufman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@davidkaufman due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@davidkaufman due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[spm32]

@davidkaufman moving you from this issue as no progress has been reported

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work has been started.

These users each claimed they can complete the work by 7 months, 1 week from now.
Please review their action plans below:

1) jberg03 has applied to start work (Funders only: approve worker | reject worker).

I'm relatively new to go but this looks fairly straight forward. Since it's already in start.go, I'll update the toml.go with hints and default value and config.go files accordingly for the --pruning flag. Is there a particular default it should be set to or is "" sufficient in the config file for --pruning as well?
2) alexjg has applied to start work (Funders only: approve worker | reject worker).

To be clear I understand the work here: The idea is to add the option to the config files which are generated by the PersistentPreRunEFn in the server package so that the pruning option is more discoverable. It will also be setable via the command line.

If that's the case this seems pretty straightforward, a case of adding a field to config.BaseConfig, much like the Config.BaseConfig.MinGasPrices attribute.

I will test using the sdk-application-tutorial package.
3) mkg20001 has been approved to start work.

I'd be interested in helping to solve this

Learn more on the Gitcoin Issue Details page.

[mkg20001]

Working on this right now

[gitcoinbot]

@mkg20001 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[mkg20001]

Submitted a WIP PR

[alexanderbez]

@mkg20001 you have to still update the changelog.

[mkg20001]

@alexanderbez Fixed, thx

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by:

1. @mkg20001

@ceresstation please take a look at the submitted work:

• PR by @mkg20001

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $151,754.36 more funded OSS Work available on the Gitcoin Issue Explorer

[mkg20001]

@ceresstation Is there any issue with the submitted work? Is this issue still actively funded?

[mkg20001]

@ceresstation Ping!

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

The funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @mkg20001.

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $126,106.25 more funded OSS Work available on the Gitcoin Issue Explorer

[mkg20001]

Thanks!