Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pruning config to toml #5090

Merged
merged 6 commits into from
Oct 3, 2019

Conversation

mkg20001
Copy link
Contributor

@mkg20001 mkg20001 commented Sep 23, 2019

Fixes #4215

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mkg20001
Copy link
Contributor Author

There don't seem to be tests related to pruning?

@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #5090 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5090      +/-   ##
==========================================
+ Coverage   54.97%   54.98%   +0.01%     
==========================================
  Files         297      297              
  Lines       18224    18225       +1     
==========================================
+ Hits        10018    10021       +3     
+ Misses       7468     7466       -2     
  Partials      738      738

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkg20001 👍

server/config/config.go Outdated Show resolved Hide resolved
server/config/toml.go Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mkg20001 mkg20001 force-pushed the feat/move-pruning-to-conf branch from b0e897c to cbe9f23 Compare October 3, 2019 17:43
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Alexander Bezobchuk <[email protected]>
@alexanderbez alexanderbez merged commit 639dad2 into cosmos:master Oct 3, 2019
@alexanderbez alexanderbez mentioned this pull request Oct 9, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move --pruning flag from gaiad start into gaiad.toml
2 participants