Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ProofSpec to be passed as JSON in 07-tendermint cli #6431

Closed
AdityaSripal opened this issue Jun 12, 2020 · 0 comments · Fixed by #6506
Closed

Allow ProofSpec to be passed as JSON in 07-tendermint cli #6431

AdityaSripal opened this issue Jun 12, 2020 · 0 comments · Fixed by #6506
Assignees
@AdityaSripal
Labels
C:CLI
Milestone
IBC 1.0 [Implemen...

Comments

@AdityaSripal
Copy link
Member

Currently the proof specs that can be passed into a MsgCreateClient using the 07-tendermint CLI are one of a couple hardcoded options.

We should allow users to pass in JSON file specifying arbitrary ICS23 ProofSpecs.

ref links:

Code:
https://github.com/cosmos/cosmos-sdk/blob/master/x/ibc/07-tendermint/client/cli/tx.go#L101

Review comment:
#6374 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdityaSripal AdityaSripal

Labels
C:CLI
Projects
None yet
Milestone
IBC 1.0 [Implementation]
Development

Successfully merging a pull request may close this issue.

Allow JSON input for proof specs in tendermint client cosmos/cosmos-sdk
2 participants
@zmanian @AdityaSripal