Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JSON input for proof specs in tendermint client #6506

Merged
merged 3 commits into from
Jun 25, 2020

Conversation

AdityaSripal
Copy link
Member

Description

closes: #6431


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #6506 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6506   +/-   ##
=======================================
  Coverage   56.34%   56.34%           
=======================================
  Files         470      470           
  Lines       28232    28232           
=======================================
  Hits        15907    15907           
  Misses      11200    11200           
  Partials     1125     1125           

@fedekunze fedekunze merged commit dcd5781 into master Jun 25, 2020
@fedekunze fedekunze deleted the aditya/json-spec branch June 25, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ProofSpec to be passed as JSON in 07-tendermint cli
2 participants