Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/keys/secp256k1: BenchmarkKeyGeneration hangs #8741

Closed
4 tasks
cuonglm opened this issue Mar 2, 2021 · 0 comments · Fixed by #8742
Closed
4 tasks

crypto/keys/secp256k1: BenchmarkKeyGeneration hangs #8741

cuonglm opened this issue Mar 2, 2021 · 0 comments · Fixed by #8742

Comments

@cuonglm
Copy link
Contributor

cuonglm commented Mar 2, 2021

Summary of Bug

BenchmarkKeyGeneration hangs forever.

Version

master

Steps to Reproduce

$ cd crypto/keys/secp256k1/
$ go1.16 test -v -run='^$' -bench=BenchmarkKeyGeneration -timeout=0

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@cuonglm cuonglm mentioned this issue Mar 2, 2021
Merged
9 tasks
@cuonglm cuonglm closed this as completed Mar 2, 2021
odeke-em pushed a commit that referenced this issue Mar 2, 2021
@cuonglm
crypto/keys/internal: use crypto/rand.Reader for generating private k…
a193522 
…ey (#8742)

genPrivKey rejects invalid fieldelems, so we must use a real reader
instead of the zero reader.

Fixes #8741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crypto/keys/internal: use crypto/rand.Reader for generating private key
1 participant
@cuonglm