Keys add returns error with --dry-run

[RiccardoM]

Summary of Bug

Running keys add [name] --dry-run returns public key already exists in keybase error.

Version

3c65c3d

Steps to Reproduce

1. Run simd keys add jack
2. Run simd keys add jack --dry-run

It will error with

Error: public key already exist in keybase

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[amaury1093]

Isn't this expected? You're adding the same key name twice.

[RiccardoM]

Isn't this expected? You're adding the same key name twice.

The problem here is that --dry-run is not considered and the key is added anyway:

$ simd keys list
[]

$ simd keys add jack --dry-run

- name: jack
  type: local
  address: cosmos1xcy3els9ua75kdm783c3qu0rfa2eplesldfevn
  pubkey: '{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"AqX+iQHClC5LCV22uQXOxIeviHVKFzbmuBSIRhhuHK3c"}'
  mnemonic: ""


**Important** write this mnemonic phrase in a safe place.
It is the only way to recover your account if you ever forget your password.

bubble father false again name any attract brave empty tattoo leisure reward ring draft army lazy maximum naive table category wire shy invest barely

$ simd keys list
- name: jack
  type: local
  address: cosmos1xcy3els9ua75kdm783c3qu0rfa2eplesldfevn
  pubkey: '{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"AqX+iQHClC5LCV22uQXOxIeviHVKFzbmuBSIRhhuHK3c"}'
  mnemonic: ""

[ryanchristo]

I can confirm that a new key is added when using --dry-run. I think the steps to reproduce are reversed and should be:

1. Run simd keys add jack --dry-run
2. Run simd keys add jack

I think the main issue here is that a key is being added when using --dry-run. I think we need to add the key in order to simulate but we should be properly cleaning it up before exiting. I'll try to take a look.