-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding cosmovisor version
command
#10103
Conversation
Visit https://dashboard.github.orijtech.com?back=0&pr=10103&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cosmovisor by default pipes everything to the binary being managed. So for version
, I think we should call the binary and then append the version. i.e.:
v1.1.0-alpha2-1-g81f1347e // from the binary being managed
Cosmovisor Version: v1.0
@spoo-bar - during the last call we learned that cosmovisor should be just a wrapper for an CC: @jgimeno |
In the
|
Co-authored-by: Robert Zaremba <[email protected]>
….com/cosmos/cosmos-sdk into spoorthi/9999-cosmovisor-version-cmd
….com/cosmos/cosmos-sdk into spoorthi/9999-cosmovisor-version-cmd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre approving. Let's validate if we want to put the cosmovisor version before the SDK version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few minor editorial suggestions, lgtm for all of the words
Co-authored-by: Barrie Byron <[email protected]>
Co-authored-by: Barrie Byron <[email protected]>
Co-authored-by: Barrie Byron <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #10103 +/- ##
=======================================
Coverage 63.72% 63.72%
=======================================
Files 573 573
Lines 53766 53766
=======================================
+ Hits 34263 34264 +1
+ Misses 17555 17554 -1
Partials 1948 1948
|
Description
Closes: #9999
version
command for cosmovisor binary versionAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change