feat: store ABCI validator updates in transient store #10175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
colin-axner,
AdityaSripal and
crodriguezvega
colin-axner
reviewed
Sep 22, 2021
Comment on lines
+101
to
+102
| // GetValidatorUpdate returns the ABCI validator power update for the current block | ||
| // by the consensus address. |
There was a problem hiding this comment.
So this is the ABCI power update for a certain block for a certain validator?
There was a problem hiding this comment.
Yes though CCV just needs GetValidatorUpdates
| @@ -19,6 +19,9 @@ const ( | |||
| // StoreKey is the string store representation | |||
| StoreKey = ModuleName | |||
|
|
|||
| // TStoreKey is the string transient store representation | |||
| TStoreKey = ModuleName | |||
There was a problem hiding this comment.
What is a transient store? Does it only exist for a block?
There was a problem hiding this comment.
IIRC, a transient store is a store that is not persisted to disk and whose state exists block by block. Correct me if I'm wrong @cwgoes
AdityaSripal
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
We should determine our approach to making changes to SDK for CCV before deciding where to put this code.
See #10153
cc: @alexanderbez
|
closing this as the issue has been moved to a different repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Expose an API to query ABCI validator set updates in the current block for use in IBC cross-chain validation (CCV)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
docs:prefix in the PR titleReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
docs:prefix in the PR title