Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make chain-id flag not strictly required for tx commands #10184

Merged
merged 6 commits into from
Sep 22, 2021
Merged

fix: make chain-id flag not strictly required for tx commands #10184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ae403f2
fix: remove chainid as a strictly required flag
technicallyty Sep 16, 2021
339a437
Merge branch 'master' into ty/fix-chain_id
technicallyty Sep 17, 2021
174b698
Merge branch 'master' into ty/fix-chain_id
technicallyty Sep 21, 2021
1fe2ef7
changelog entry
technicallyty Sep 21, 2021
72ad96b
Merge branch 'ty/fix-chain_id' of https://github.com/cosmos/cosmos-sd…
technicallyty Sep 21, 2021
b784b28
Merge branch 'master' into ty/fix-chain_id
mergify[bot] Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
+ [\#10061](https://github.com/cosmos/cosmos-sdk/pull/10061) Ensure that `LegacyAminoPubKey` struct correctly unmarshals from JSON
* (server) [#10016](https://github.com/cosmos/cosmos-sdk/issues/10016) Fix marshaling of index-events into server config file.
* (x/feegrant) [\#10049](https://github.com/cosmos/cosmos-sdk/issues/10049) Fixed the error message when `period` or `period-limit` flag is not set on a feegrant grant transaction.
* [\#10184](https://github.com/cosmos/cosmos-sdk/pull/10184) Fixed CLI tx commands to no longer explicitly require the chain-id flag as this value can come from a user config.


### State Machine Breaking
Expand Down
2 changes: 0 additions & 2 deletions client/flags/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ func AddTxFlagsToCmd(cmd *cobra.Command) {

// --gas can accept integers and "auto"
cmd.Flags().String(FlagGas, "", fmt.Sprintf("gas limit to set per-transaction; set to %q to calculate sufficient gas automatically (default %d)", GasFlagAuto, DefaultGasLimit))

cmd.MarkFlagRequired(FlagChainID)
}

// AddPaginationFlagsToCmd adds common pagination flags to cmd
Expand Down