fix: replace reflect.Typeof.Name with fmt.Sprintf("%T") #10392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10392 +/- ##
==========================================
- Coverage 64.28% 64.27% -0.01%
==========================================
Files 572 572
Lines 54230 54230
==========================================
- Hits 34862 34858 -4
- Misses 17387 17390 +3
- Partials 1981 1982 +1
|
Per https://golang.org/pkg/fmt#hdr-Printing, Go's fmt "%T" specifier prints out the underlying type hence we don't need to invoke reflect.Typeof(key).Name() just to get it. This change was discovered while examining Informal Systems' static analyzers that want to flag certain packages. Fixes #10391
tac0turtle
approved these changes
Oct 18, 2021
tac0turtle
changed the title
tac0turtle
added
A:automerge
amaury1093
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://golang.org/pkg/fmt#hdr-Printing, Go's fmt "%T" specifier
prints out the underlying type hence we don't need to invoke
reflect.Typeof(key).Name() just to get it. This change was discovered
while examining Informal Systems' static analyzers that want to flag
certain packages.
Fixes #10391