build: fix build environment for the liveness test #10551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creachadair
changed the title
creachadair
force-pushed
the
mjf/liveness-test
branch
from
26401a0 to
085279f
Compare
creachadair
force-pushed
the
mjf/liveness-test
branch
from
6c3bdfb to
97ff10f
Compare
- Use layers to more advantage. - Include bash in the run container. - Put writable output onto a volume.
Do not merge.
creachadair
force-pushed
the
mjf/liveness-test
branch
from
97ff10f to
8f33ca5
Compare
tac0turtle
approved these changes
Nov 15, 2021
This reverts commit 8f33ca5.
mergify bot
pushed a commit
that referenced
this pull request
Nov 15, 2021
Extracted from #10210. Make the test more reproducible, so that it does not require coordination between the build container and the run container. - Use layers to more advantage. - Include bash in the run container. - Put writable output onto a volume. (cherry picked from commit 70a3a90) # Conflicts: # Makefile
robert-zaremba
added a commit
that referenced
this pull request
Nov 15, 2021
…10552) * build: fix build environment for the liveness test (#10551) Extracted from #10210. Make the test more reproducible, so that it does not require coordination between the build container and the run container. - Use layers to more advantage. - Include bash in the run container. - Put writable output onto a volume. (cherry picked from commit 70a3a90) # Conflicts: # Makefile * fix conflict Co-authored-by: M. J. Fromberger <[email protected]> Co-authored-by: Robert Zaremba <[email protected]>
blewater
pushed a commit
to e-money/cosmos-sdk
that referenced
this pull request
Dec 8, 2021
Extracted from cosmos#10210. Make the test more reproducible, so that it does not require coordination between the build container and the run container. - Use layers to more advantage. - Include bash in the run container. - Put writable output onto a volume.
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
…0551) (cosmos#10552) * build: fix build environment for the liveness test (cosmos#10551) Extracted from cosmos#10210. Make the test more reproducible, so that it does not require coordination between the build container and the run container. - Use layers to more advantage. - Include bash in the run container. - Put writable output onto a volume. (cherry picked from commit 70a3a90) # Conflicts: # Makefile * fix conflict Co-authored-by: M. J. Fromberger <[email protected]> Co-authored-by: Robert Zaremba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #10210.
Make the test more reproducible, so that it does not require coordination
between the build container and the run container.
Note to reviewers: I included a stub Go file to trigger the CI. That should be dropped before merging this change.