Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(depinject): add preference feature #12202

Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jun 9, 2022

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc changed the base branch from main to kocubinski/depinject-prefer June 9, 2022 15:20
@aaronc aaronc marked this pull request as ready for review June 9, 2022 15:36
@aaronc aaronc requested a review from a team as a code owner June 9, 2022 15:36
Copy link
Member

@kocubinski kocubinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to thoroughly test error cases and preferences.

@aaronc aaronc changed the title tests(depinject): add preference feature test(depinject): add preference feature Jun 9, 2022
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. I'm OK with this approach if it's used in conjunction with normal tests too. Is that OK?

@aaronc
Copy link
Member Author

aaronc commented Jun 9, 2022

Seems reasonable to me. I'm OK with this approach if it's used in conjunction with normal tests too. Is that OK?

There's nothing that precludes other testing styles from being used

@kocubinski kocubinski merged commit 9e49d79 into kocubinski/depinject-prefer Jun 9, 2022
@kocubinski kocubinski deleted the aaronc/depinject-prefer-feature branch June 9, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants