-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add x/auth app wiring integration tests #12329
Conversation
…ita/add-auth-integration-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a few nits.
…ita/add-auth-integration-tests
Co-authored-by: Julien Robert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you as well add docs, like here https://github.com/cosmos/cosmos-sdk/tree/main/x/authz/spec ?
We should also probably use a commit hash instead of |
…ita/add-auth-integration-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Codecov Report
@@ Coverage Diff @@
## main #12329 +/- ##
==========================================
- Coverage 65.88% 65.86% -0.03%
==========================================
Files 676 676
Lines 71296 71298 +2
==========================================
- Hits 46975 46962 -13
- Misses 21691 21705 +14
- Partials 2630 2631 +1
|
Description
ref: #12302
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change