feat(core/appconfig): add support for golang_bindings in app.yaml #12367
Conversation
x/nft/testutil/app.yaml
Outdated
| @@ -1,3 +1,5 @@ | |||
| golang_bindings: | |||
There was a problem hiding this comment.
Can remove this from x/nft if we don't like it, but I wanted to ensure this change was working end to end, and it seems to be.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // | ||
| // golang_bindings: | ||
| // interfaceType: implementationType | ||
| map<string, string> golang_bindings = 2; |
There was a problem hiding this comment.
Not sure we consider maps in proto messages kosher yet. We can serialize them deterministically, but I think the assumption is still that we shouldn't use them
There was a problem hiding this comment.
Changed to a typed message
…ppconfig_bindings
| string interface_type = 1; | ||
|
|
||
| // implementation is the implementing type which will be supplied when an input of type interface is requested | ||
| string implementation = 2; |
There was a problem hiding this comment.
How about simply:
| string interface_type = 1; | |
| // implementation is the implementing type which will be supplied when an input of type interface is requested | |
| string implementation = 2; | |
| string iface = 1; | |
| // implementation is the implementing type which will be supplied when an input of type interface is requested | |
| string impl = 2; |
There was a problem hiding this comment.
could also be interface and impl
There was a problem hiding this comment.
@julienrbrt @alexanderbez What do you think about naming? I like shorter names
There was a problem hiding this comment.
These aren't super long field names. I personally don't see much value add in the abbreviations.
…ppconfig_bindings
…ppconfig_bindings
…ppconfig_bindings
Description
Closes: #11910
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change