Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use mocks for x/mint testing #12468

Merged
merged 14 commits into from
Jul 8, 2022
Merged

refactor: Use mocks for x/mint testing #12468

merged 14 commits into from
Jul 8, 2022

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented Jul 6, 2022

Description

Ref: #12398


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@facundomedica facundomedica marked this pull request as ready for review July 7, 2022 21:34
@facundomedica facundomedica requested a review from a team as a code owner July 7, 2022 21:34
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now x/mint keeper pkg tests no longer rely on simapp correct?

@facundomedica
Copy link
Member Author

facundomedica commented Jul 8, 2022

So now x/mint keeper pkg tests no longer rely on simapp correct?

Yes. We still have to figure out how to stop running a full app for some other tests, like the one in x/mint/module_test.go; but that's a bigger problem that should be fixed when we get to mock Tendermint.

@facundomedica facundomedica added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 8, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #12468 (ea82a89) into main (5ef43f4) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12468      +/-   ##
==========================================
- Coverage   65.54%   65.51%   -0.03%     
==========================================
  Files         687      687              
  Lines       71707    71707              
==========================================
- Hits        46999    46981      -18     
- Misses      22054    22075      +21     
+ Partials     2654     2651       -3     
Impacted Files Coverage Δ
x/mint/keeper/migrator.go 0.00% <0.00%> (-71.43%) ⬇️
x/mint/keeper/genesis.go 0.00% <0.00%> (-40.00%) ⬇️
x/mint/keeper/keeper.go 62.50% <0.00%> (-14.29%) ⬇️
x/mint/keeper/querier.go 0.00% <0.00%> (-2.86%) ⬇️

@mergify mergify bot merged commit 411c272 into main Jul 8, 2022
@mergify mergify bot deleted the facu/mint-mocks branch July 8, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Simulations C:x/mint Type: Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants