-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use mocks for x/mint testing #12468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now x/mint keeper
pkg tests no longer rely on simapp
correct?
Yes. We still have to figure out how to stop running a full app for some other tests, like the one in x/mint/module_test.go; but that's a bigger problem that should be fixed when we get to mock Tendermint. |
Codecov Report
@@ Coverage Diff @@
## main #12468 +/- ##
==========================================
- Coverage 65.54% 65.51% -0.03%
==========================================
Files 687 687
Lines 71707 71707
==========================================
- Hits 46999 46981 -18
- Misses 22054 22075 +21
+ Partials 2654 2651 -3
|
Description
Ref: #12398
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change