-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate x/params usage in x/auth #12475
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likhita-809
requested review from
aaronc,
alexanderbez,
amaury1093,
atheeshp,
JeancarloBarrios,
julienrbrt and
tac0turtle
July 7, 2022 10:17
julienrbrt
reviewed
Jul 7, 2022
alexanderbez
reviewed
Jul 7, 2022
…ita/migrate-auth-params
…ita/migrate-auth-params
alexanderbez
approved these changes
Jul 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #12475 +/- ##
==========================================
- Coverage 65.33% 65.29% -0.05%
==========================================
Files 687 691 +4
Lines 71709 71768 +59
==========================================
+ Hits 46852 46860 +8
- Misses 22226 22274 +48
- Partials 2631 2634 +3
|
alexanderbez
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Jul 11, 2022
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* generate proto files * wip * wip: fix tests * wip: add tests * fix tests * fix tests * add changelog * address review comments * address review comments * add err check for setparams * updates Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
C:Rosetta
Issues and PR related to Rosetta
C:x/auth
C:x/bank
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #12283
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change