Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(group)!: read the decision policy from disk in group CLI #12551

Merged
merged 9 commits into from
Jul 13, 2022
Merged

feat(group)!: read the decision policy from disk in group CLI #12551

merged 9 commits into from
Jul 13, 2022

Conversation

julienrbrt
Copy link
Member

Description

Closes: #12550

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt changed the title feat!(group): read the decision policy from disk in group CLI feat(group)!: read the decision policy from disk in group CLI Jul 13, 2022
@julienrbrt julienrbrt marked this pull request as ready for review July 13, 2022 11:44
@julienrbrt julienrbrt requested a review from a team as a code owner July 13, 2022 11:44
@julienrbrt julienrbrt added the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Jul 13, 2022
alexanderbez
alexanderbez approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Small nit. Cobra now has an explicit Example field which we should use instead of the ad-hoc example we add in the Long descriptions.

@julienrbrt julienrbrt merged commit a2744ea into main Jul 13, 2022
@julienrbrt julienrbrt deleted the julien/consistent-group-cli-behavior branch July 13, 2022 17:05
mergify bot pushed a commit that referenced this pull request Jul 13, 2022
@julienrbrt @mergify
feat(group)!: read the decision policy from disk in group CLI (#12551)
6bc72a1 
(cherry picked from commit a2744ea)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jul 13, 2022
Merged
tac0turtle pushed a commit that referenced this pull request Jul 15, 2022
@mergify @julienrbrt
feat(group)!: read the decision policy from disk in group CLI (backport
ebbcfd0 
#12551) (#12565)

* feat(group)!: read the decision policy from disk in group CLI (#12551)

(cherry picked from commit a2744ea)

# Conflicts:
#	CHANGELOG.md

* fix conflict

Co-authored-by: Julien Robert <[email protected]>
@neutron-robot neutron-robot mentioned this pull request Feb 7, 2024
Closed
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@mergify @julienrbrt @JeancarloBarrios
feat(group)!: read the decision policy from disk in group CLI (backport
9df9de3 
cosmos#12551) (cosmos#12565)

* feat(group)!: read the decision policy from disk in group CLI (cosmos#12551)

(cherry picked from commit a2744ea)

# Conflicts:
#	CHANGELOG.md

* fix conflict

Co-authored-by: Julien Robert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

Assignees

@amaury1093 amaury1093

@likhita-809 likhita-809

Labels
backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:CLI C:x/group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read the decision policy from disk in group CLI
4 participants
@julienrbrt @alexanderbez @amaury1093 @likhita-809