refactor(types): remove dependency on simapp in integration test #12587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocubinski
commented
Jul 14, 2022
| "cosmossdk.io/depinject" | ||
| ) | ||
|
|
||
| var beginBlockOrder = []string{ |
There was a problem hiding this comment.
Note: I am using naked strings here to avoid a hard dependency on modules from the configurator package.
kocubinski
commented
Jul 14, 2022
| "github.com/cosmos/cosmos-sdk/x/bank/testutil" | ||
| "github.com/cosmos/cosmos-sdk/x/bank/types" | ||
| _ "github.com/cosmos/cosmos-sdk/x/params" | ||
| ) |
There was a problem hiding this comment.
Additions are the immediate module dependencies this integration test requires, e.g.
_ "github.com/cosmos/cosmos-sdk/x/params"
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+104
to
+106
| for _, m := range options { | ||
| modules = append(modules, m) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
Codecov Report
@@ Coverage Diff @@
## main #12587 +/- ##
==========================================
- Coverage 65.63% 65.20% -0.44%
==========================================
Files 711 693 -18
Lines 73099 71836 -1263
==========================================
- Hits 47980 46838 -1142
+ Misses 22457 22368 -89
+ Partials 2662 2630 -32 |
julienrbrt
reviewed
Jul 15, 2022
| @@ -0,0 +1,109 @@ | |||
| package configurator | |||
julienrbrt
approved these changes
Jul 15, 2022
julienrbrt
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #12584
depinjectsimappreplaced by 3 dependencies on modules used in the integration test: bank, auth, and params.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change