-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use mocks for x/distribution #12889
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12889 +/- ##
==========================================
- Coverage 55.87% 53.23% -2.65%
==========================================
Files 646 643 -3
Lines 54895 54859 -36
==========================================
- Hits 30675 29204 -1471
- Misses 21762 23333 +1571
+ Partials 2458 2322 -136
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just curious why simulation tests are moving tests/integration
, it does not use simapp.
We use |
I suppose I need to run |
… into facu/distr-mocks
Description
Use mocks and move integration tests to the right directory.
Closes: #12758
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change