test(gov): Refactor x/gov keeper tests to use mocks #12988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
Codecov Report
@@ Coverage Diff @@
## main #12988 +/- ##
==========================================
- Coverage 55.87% 55.58% -0.30%
==========================================
Files 646 644 -2
Lines 54895 54935 +40
==========================================
- Hits 30675 30535 -140
- Misses 21762 21932 +170
- Partials 2458 2468 +10
|
2 tasks
amaury1093
commented
Aug 25, 2022
Comment on lines
+19
to
+23
| // KeeperTestSuite only tests gov's keeper logic around tallying, since it | ||
| // relies on complex interactions with x/staking. | ||
| // | ||
| // It also uses simapp (and not a depinjected app) because we manually set a | ||
| // new app.StakingKeeper in `createValidators`. |
There was a problem hiding this comment.
Only tallying tests have been moved here. I don't think it's easy to mock them.
Comment on lines
+20
to
+25
| // BondDenomProvider is a subset of the staking keeper's public interface that | ||
| // provides the staking bond denom. It is used in arguments in this package's | ||
| // functions so that a mock staking keeper can be passed instead of the real one. | ||
| type BondDenomProvider interface { | ||
| BondDenom(ctx sdk.Context) string | ||
| } |
There was a problem hiding this comment.
Any objections to this? Or better ideas?
| ) | ||
|
|
||
| func (suite *KeeperTestSuite) TestSubmitProposalReq() { | ||
| govAcct := suite.app.GovKeeper.GetGovernanceAccount(suite.ctx).GetAddress() | ||
| suite.reset() |
There was a problem hiding this comment.
I added this line in some tests. If I don't, I have an off-by-1 error in proposal ID, only when running the whole suite. Like some other test got run before and created a proposal or something
Resetting makes each test more independent.
alexanderbez
approved these changes
Aug 25, 2022
julienrbrt
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #12752
tests/integration/gov/keeper, see test(gov): Refactor x/gov keeper tests to use mocks #12988 (comment)x/gov/keepertests, use mocks insteadsimappreferences from module tests and simulations #13043)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change