docs: Liquid staking ADR #13239
Merged
docs: Liquid staking ADR #13239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akure
reviewed
Sep 13, 2022
There was a problem hiding this comment.
@marbar3778 @hxrts @okwme any interest in taking a look at this?
tac0turtle
reviewed
Sep 19, 2022
hxrts
reviewed
Sep 19, 2022
hxrts
reviewed
Sep 19, 2022
hxrts
reviewed
Sep 19, 2022
hxrts
reviewed
Sep 19, 2022
|
|
||
| A new governance parameter is introduced that defines the ratio of exempt to issued tokenized shares. This is called the exemption factor. | ||
|
|
||
| Min self delegation is removed from the staking system with the expectation that it will be replaced by the exempt delegations sytem. The exempt delegation system allows multiple accounts to demonstrate economic alignment with the validator operator as team members, partners etc without co-mingling funds. The exempt delegation will likely be required to grow the validators business under widespread adoption of liquid staking and where governence sets the exemption factor. |
There was a problem hiding this comment.
I keep forgetting if a larger exemption factor means more exempt delegations are required to issue delegation shares or if it's the other way around. Can we get a sentence that states that clearly?
hxrts
reviewed
Sep 19, 2022
hxrts
reviewed
Sep 19, 2022
hxrts
reviewed
Sep 19, 2022
hxrts
reviewed
Sep 19, 2022
hxrts
reviewed
Sep 19, 2022
hxrts
reviewed
Sep 19, 2022
hxrts
reviewed
Sep 19, 2022
hxrts
reviewed
Sep 19, 2022
tac0turtle
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
@zmanian could you address sam's comments then we can merge
Co-authored-by: Sam Hart <[email protected]>
Co-authored-by: Sam Hart <[email protected]>
Co-authored-by: Sam Hart <[email protected]>
Co-authored-by: Sam Hart <[email protected]>
Co-authored-by: Sam Hart <[email protected]>
Co-authored-by: Sam Hart <[email protected]>
Co-authored-by: Sam Hart <[email protected]>
Co-authored-by: Sam Hart <[email protected]>
Co-authored-by: Sam Hart <[email protected]>
Co-authored-by: Sam Hart <[email protected]>
Co-authored-by: Sam Hart <[email protected]>
julienrbrt
requested review from
likhita-809,
julienrbrt,
aaronc,
amaury1093,
atheeshp,
facundomedica,
JeancarloBarrios and
kocubinski
faddat
approved these changes
Sep 23, 2022
Co-authored-by: likhita-809 <[email protected]>
Co-authored-by: likhita-809 <[email protected]>
Co-authored-by: likhita-809 <[email protected]>
Co-authored-by: likhita-809 <[email protected]>
fedekunze
reviewed
Oct 19, 2022
|
|
||
| ### `MsgTokenizeShares` | ||
|
|
||
| The MsgTokenizeShares message is used to create tokenize delegated tokens. This message can be executed by any delegator who has positive amount of delegation and after execution the specific amount of delegation disappear from the account and share tokens are provided. Share tokens are denominated in the validator and record id of the underlying delegation. |
There was a problem hiding this comment.
Share tokens are denominated in the validator and record id of the underlying delegation.
It's not clear what the record id is here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADR to upgrade the staking/distr/slashing module to support the liquid staking design from #12917