-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autocli app wiring + remote info support #13281
Conversation
ah I see now. hopefully it expands into something more cause client/v2 but it only doing one thing defeats the purpose of calling it v2 |
That's the plan. I'm hoping to have a new golang tx client and keyring stuff eventually. Have done a PoC of some that stuff. We can discuss more when we get there. |
You okay to move forward with this @tac0turtle ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one question but looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed tiny nits (import group and make proto-gen) to remove some diff here.
Description
Closes #13282
This PR adds:
cosmossdk.io/core/appmodule.AppModule
tag interface which implements the core API using extension interfaces instead of a handler structAppModule
extension interfaces for autocli/cosmos.app.v1alpha1.Query/FileDescriptorSet
- for the full file descriptor set/cosmos.autocli.v1.RemoteInfoService/AppOptions
- autocli app options for dynamic CLI generationAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change