-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Improve AllocateTokens #13524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
changed the title
refactor: Improve Allocation
refactor: Improve AllocateTokens
Oct 12, 2022
alexanderbez
added
backport/0.45.x
backport/0.46.x
PR scheduled for inclusion in the v0.46's next stable release
labels
Oct 12, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13524 +/- ##
==========================================
+ Coverage 53.78% 53.92% +0.13%
==========================================
Files 653 643 -10
Lines 56830 55475 -1355
==========================================
- Hits 30567 29915 -652
+ Misses 23819 23156 -663
+ Partials 2444 2404 -40 |
julienrbrt
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mergify bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
(cherry picked from commit 7781cdb) # Conflicts: # x/distribution/keeper/allocation.go
mergify bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
(cherry picked from commit 7781cdb) # Conflicts: # x/distribution/keeper/allocation.go
alexanderbez
pushed a commit
that referenced
this pull request
Oct 13, 2022
alexanderbez
pushed a commit
that referenced
this pull request
Oct 13, 2022
19 tasks
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/0.46.x
PR scheduled for inclusion in the v0.46's next stable release
C:x/distribution
distribution module related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #13520
Note, this is NOT SM breaking. Just a minor perf improvement to not do the same math over and over again.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change