Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use built-in cobra completion command #13548

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Oct 13, 2022

Description

I noticed that in simd we're using tmcli.NewCompletionCmd instead of cobra's built-in completion command. Maybe at some point cobra didn't have this functionality, but now the built-in functionality is better and also supports fish and powershell. So we should encourage apps to just use default cobra completion.

Not sure if any CHANGELOG entry is needed because this is just simapp.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #13548 (3114340) into main (fa2cb40) will decrease coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13548      +/-   ##
==========================================
- Coverage   53.93%   53.82%   -0.12%     
==========================================
  Files         643      653      +10     
  Lines       55464    56825    +1361     
==========================================
+ Hits        29916    30586     +670     
- Misses      23148    23795     +647     
- Partials     2400     2444      +44     
Impacted Files Coverage Δ
simapp/simd/cmd/root.go 70.23% <ø> (ø)
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
x/staking/simulation/operations.go 74.54% <0.00%> (-1.38%) ⬇️
simapp/state.go 0.00% <0.00%> (ø)
simapp/app.go 77.84% <0.00%> (ø)
simapp/genesis_account.go 100.00% <0.00%> (ø)
simapp/simd/cmd/genaccounts.go 89.09% <0.00%> (ø)
simapp/genesis.go 100.00% <0.00%> (ø)
simapp/export.go 11.94% <0.00%> (ø)
simapp/test_helpers.go 30.25% <0.00%> (ø)
... and 3 more

@alexanderbez alexanderbez merged commit 05d1138 into main Oct 14, 2022
@alexanderbez alexanderbez deleted the aaronc/remove-tmcli-complete branch October 14, 2022 02:03
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants